[PATCH] (3rd attempt) re-implement void kurlcompletion.cpp|DirectoryListThread::run() with Qt calls
faure at kde.org
Fri Dec 12 20:22:56 GMT 2008
On Saturday 28 June 2008, Michael O'Shea wrote:
> here's my latest attempt at this patch.
> Please note :
> - on Linux, the behaviour should be identical to before the patch
> - slight change in behaviour on Windows: Qt does not regard files that start
> with "." as being hidden. Only the file system's "hidden" attribute will be
> considered. This means that apps should use an OS-independent call to create
> hidden files, it is no longer enough to make a filename start with "." for
> it to be hidden on all OSes. Visible effect : on Windows, URL completion of
> file system paths will include directories starting with "." unless their
> "hidden" attribute is set.
> - enum QDir::Filter has some interesting values such as QDir::NoSymLinks and
> QDir::System (http://doc.trolltech.com/4.3/qdir.html#Filter-enum). The
> semantics of DirectoryListThread don't allow for exploitation of these flags
> and I have not made any attempt to include them. Maybe for a later effort ?
> - use cases :
> a) Konqueror (type "/", various absolute paths, in the address bar)
> checks OK
> b) Dolphin (type "/", various absolute paths, in the address bar)checks
> c) Dolphin, right-click on file >> Open with ... dialogue correctly
> allows to browse folders whilst only displaying executable files.
> There, I hope it works OK this time round.
> Thanks for the continued patience in dealing with my efforts.
Damn I missed this email back then and now the patch doesn't apply anymore;
do you have a svn checkout where the patch was applied when doing svn update
regularly? In that case you can make an updated patch more easily than me
attempting to merge it by hand.
I'm not sure if this can go into 4.2 or only be applied once trunk is open again,
but it would certainly be good to start testing it.
Sorry for the huge delay; I still think this change is a good idea, though :)
(more maintainable code)
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel