better proxy support

Thiago Macieira thiago at kde.org
Sat Dec 6 17:17:11 GMT 2008


Xavier Vello wrote:
>Hello
>
>In KDE, it's impossible to use a proxy only for http (and not https nor
> ftp), which is quite annoying, especially for ftp.
>The attached patch disables proxy for http/https when the proxy url is
> empty (no host), allowing to use proxy only for http and direct https.
> Please review it before I commit it.
>
>I can't test ftp proxy support, is someone willing to do the same patch
> for ftp ? (checking proxyUrl.hasHost() should be enough).

Go ahead.

That's one of the KDE 3-to-4 porting issues: an empty URL is considered a 
valid URL, so the logic was broken in the process.

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081206/c1aa6d89/attachment.sig>


More information about the kde-core-devel mailing list