[Patch] Fix undeleted "static QFont *_font" in kglobalsettings.cpp

Friedrich W. H. Kossebau kossebau at kde.org
Thu Dec 4 15:59:19 GMT 2008


Am Donnerstag, 4. Dezember 2008, um 14:41 Uhr, schrieb Thiago Macieira:
> On Thursday 04 December 2008 14:16:15 Friedrich W. H. Kossebau wrote:
> >         inline GlobalSettingsData* GlobalSettingsData::self()
> >         {
> >                 K_GLOBAL_STATIC(GlobalSettingsData, s_self)
> >                 return s_self;
> >         }
>
> Don't put K_GLOBAL_STATIC inside a function.

Why?

At least I can't find a reason in the definition of 
K_GLOBAL_STATIC/K_GLOBAL_STATIC_WITH_ARGS.

And it seems to have worked for KGlobalSettings* KGlobalSettings::self()
in KDE 4.{0,1}.

If there is a reason it should be added to the APIDOX, please.

Cheers
Friedrich
-- 
Okteta - KDE 4 Hex Editor - http://utils.kde.org/projects/okteta


More information about the kde-core-devel mailing list