[Patch] Fix undeleted "static QFont *_font" in kglobalsettings.cpp
thiago at kde.org
Thu Dec 4 13:41:48 GMT 2008
On Thursday 04 December 2008 14:16:15 Friedrich W. H. Kossebau wrote:
> inline GlobalSettingsData* GlobalSettingsData::self()
> K_GLOBAL_STATIC(GlobalSettingsData, s_self)
> return s_self;
Don't put K_GLOBAL_STATIC inside a function.
Also, your class doesn't start with a K. Please don't pollute the global
namespace (remember that not all compilers support hidden visibility). The
same goes for FontData.
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Senior Software Engineer - Nokia, Qt Software
Qt Software is hiring - ask me
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: This is a digitally signed message part.
More information about the kde-core-devel