[PATCH] thread-safe queued KDialogs

Sebastian Trueg trueg at kde.org
Tue Dec 2 15:22:36 GMT 2008


well, this was a waste of time. Too bad it was not only my time which 
was wasted. Sorry for the useless noise. :(
After so many incarnations of the patch.... I still did not realize its 
uselessness...

well, off to fix the actual (original) issue: making KMessage thread-safe.

David Faure wrote:
> On Saturday 22 November 2008, Sebastian TrĂ¼g wrote:
>> The attached patch makes queued dialogs thread-safe. With it, queued 
>> KMessagesBoxes and thus, the default KMessage messasge handler.
>> This fixes a crash in KRunner when KMimeType tried to complain about missing 
>> mimetypes using KMessage which in turn uses KMessageBox which tries to open a 
>> QWidget from a thread which is not the GUI thread which triggers an assert. :)
> 
> I don't understand how this can work at all.
> You're calling this in
> void KDialogQueue::queueDialog( QDialog *dialog )
> but that method can obviously only be called from the GUI thread,
> since it's not allowed to create widgets and dialogs from other threads.
> 




More information about the kde-core-devel mailing list