Review needed: Add support of lzma in KDE

Thiago Macieira thiago at
Sun Aug 24 12:57:39 BST 2008

Nicolas Lécureuil wrote:
>> In kdelibs/kdecore/compression/klzmafilter.cpp, you have a #define
>> with two underscores. Two underscores are reserved, so you must be
>> changing some gcc and/or glibc specific configuration. Can you find a
>> solution without that?
>what   can be  be done is to replace is to replace
>LZMA_VLI_VALUE_UNKNOWN by  (uint64_t)-1

That is not the constant I was talking about.

I want you to remove this line:

This has nothing to do with LZMA_VLI_VALUE_UNKNOWN.

Note that UINT64_MAX (defined in stdint.h) is a C99 feature and so is 
inttypes.h. They can't be used in C++ code.

  Thiago Macieira  -  thiago (AT) - thiago (AT)
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list