[PATCH] Set program icon name by KAboutData

Lubos Lunak l.lunak at suse.cz
Mon Apr 21 15:09:24 BST 2008


On Monday 21 of April 2008, Aaron J. Seigo wrote:
> On Sunday 20 April 2008, Friedrich W. H. Kossebau wrote:
> > Which could ask me to adapt the whole file, as I wrote the code by
> > example (TM). But that would kill "svn blame". So now go for mixed style
> > in a file?
>
> when we first came to the agreement for the kdelibs style it was also

 Just curious, the agreement part was when Zack posted the proposal in a way 
that basically dismissed any discussion of it or when everybody got tired of 
the flamewar and the Qt style then got pushed in?

> generally agreed (as in "never made into an official policy, just
> discussed")

 Funny definition of agreement. Quite fitting this case, though.

> that we would improve code to follow the style guide as we 
> touched it. so if a method was significantly changed, we'd redo the method;
> if it just touches as few lines, then the local context would be improved.
>
> this was a compromise between moving to the new style in all kdelibs code
> and not killing svn blame's usefulness.
>
> eventualy, through a natural process of "reverse erosion" (?) the codebase
> will become more and more consistent.
>
> > I personally would use the kdelibs coding style only for completely new
> > files
>
> one of the reasons for having a style guide is global consistency, though

 And the other is that you, with all the things you manage to do, still feel 
bored and have time to point out every single space wrong to others? It's 
really such a pity none of these people with magic time abilities have ever 
written it down into some Clones-HOWTO. I'm going to need it too, the day 
somebody starts picking up on my patches.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz




More information about the kde-core-devel mailing list