[PATCH] Set program icon name by KAboutData

Aaron J. Seigo aseigo at kde.org
Mon Apr 21 13:54:04 BST 2008


On Sunday 20 April 2008, Friedrich W. H. Kossebau wrote:
> Which could ask me to adapt the whole file, as I wrote the code by example
> (TM). But that would kill "svn blame". So now go for mixed style in a file?

when we first came to the agreement for the kdelibs style it was also 
generally agreed (as in "never made into an official policy, just discussed") 
that we would improve code to follow the style guide as we touched it. so if 
a method was significantly changed, we'd redo the method; if it just touches 
as few lines, then the local context would be improved.

this was a compromise between moving to the new style in all kdelibs code and 
not killing svn blame's usefulness.

eventualy, through a natural process of "reverse erosion" (?) the codebase 
will become more and more consistent.

> I personally would use the kdelibs coding style only for completely new 
> files

one of the reasons for having a style guide is global consistency, though =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080421/f7e19075/attachment.sig>


More information about the kde-core-devel mailing list