[PATCH] Set program icon name by KAboutData

Friedrich W. H. Kossebau kossebau at kde.org
Sat Apr 19 13:21:45 BST 2008


Hi,

I would like to propose to extend KAboutData about the property 
programIconName.

While trying to find out what icon (names) are to be used for a program I saw 
that in the process to follow the freedesktop icon naming spec for those 
programs that use such an adapted icon (name) which differs from the program 
name there was an extra call added to (re)set the window icon, like
	QApplication::setWindowIcon( KIcon( "utilities-file-archiver" ) );
This is needed because KApplication sets on start the icon by the 
componentName, which is KAboutData->appName():
	q->setWindowIcon(KIcon(componentData.componentName()));

I feel that a call like
	aboutData.setProgramIconName( "utilities-file-archiver" );
would be much more consistent and readable for our plain developer.
And KApplication would be adapted to simply use 
	q->setWindowIcon(KIcon(componentData.aboutData()->programIconName()));

Attached patch extends KAboutData about the property programIconName and makes 
KApplication use that property.

Okay to apply on next Monday? I will also adapt all programs which directly 
set the icon.

Friedrich
-------------- next part --------------
A non-text attachment was scrubbed...
Name: programIconNameAddedToKAboutData.patch
Type: text/x-diff
Size: 2600 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080419/a196c762/attachment.patch>


More information about the kde-core-devel mailing list