KSystemTrayIcon on system without X11

[Christian Ehrlicher]

Carlo schrieb:
> On Sun, Apr 6, 2008 at 10:08 AM, Christian Ehrlicher
> <Ch.Ehrlicher at gmx.de> wrote:
>> Carlo schrieb:
>>
>>
>>
>>> Hi,
>>> right now clicking on a KSystemTrayIcon to show/hide the main window
>>> works only on X11 because there is an ifdef with X11 specific code, so
>>> i've made a patch to use setVisible on other platforms but i was
>>> wondering if it's a problem to use setVisibile or the x11 code is just
>>> to handle specific features like multiple desktops
>>>
>>>
>>  Your implementation is wrong. I'm currently trying to figure out how to
>> make KSystemTrayIcon::activateOrHide() behave correct on windows.
>>  KSystemTrayIcon::minimizeRestore() already works and I can check it in if
>> you want.
>>
>>
>>  Christian
>>
>>
> Why is wrong? seems to work for me
> 
There's a difference between 'working' and 'working like described'.
See here:

// if the window is not the active one, show it if needed, and activate it
// (just like taskbar); otherwise hide it
void KSystemTrayIcon::activateOrHide( QSystemTrayIcon::ActivationReason 
reasonCalled )
You just make it visible or not.

And minimizeRestore() also brings the window on top of the z-order, you 
patch doesn't do this.


Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 258 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080406/f21d47dc/attachment.sig>