[PATCH] Make WhatsThis texts appear for composite widgets

David Jarvie lists at astrojar.org.uk
Sat Sep 29 16:14:41 BST 2007


KWhatsThisManager outputs a default WhatsThis text inviting the user to submit 
suggestions for texts whenever the user asks for a WhatsThis text for a 
widget which doesn't have one. However, when a widget has child widgets, and 
the parent widget does have a WhatsThis text, the default text is output for 
all the child widgets instead of outputting the parent's WhatsThis text. This 
means that many widgets which actually do have WhatsThis texts display 
instead the default text, simply because each individual component of a 
composite widget hasn't been separately supplied with (the same) WhatsThis 
text. This is a real reduction in usability, the opposite of what 
KWhatsThisManager is intended to achieve.

I attach a patch which checks for the existence of a WhatsThis text in the 
parent (and grandparent, etc...) widget before deciding to output the default 
WhatsThis message.

-- 
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/kalarm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kwhatsthis.diff
Type: text/x-diff
Size: 1104 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070929/da482c34/attachment.diff>


More information about the kde-core-devel mailing list