KDE/kdelibs/kdeui/colors

[Thomas Zander]

Hi,

On Saturday 15 September 2007 21:47:24 Matthew Woehlke wrote:
> > The fact that you like them to the extend you would  a) ok me
> > changing it and  b) revert it 30 seconds after I commit well, thats
> > just not how we do things in KDE.
>
> Please look closer at what I actually did. Yes, I undid the unnecessary
> gutting that you did. What I did *not* revert is the defaults for the
> Inactive effects, which is what I was expecting you to change.

I'll reiterate that its not about the code, its about how we all work 
together that went wrong here.
Simple rule; don't revert a patch without at least having had a talk 
about why, what etc.

> > Point in fact; the colors stuff is not your part of the KDE svn that
> > you rule in and can ignore everybodies opinion about.
>
> Ok, but I hope you can understand that I'm not objecting to you
> changing the effects defaults, I'm objecting to you completely
> restructuring the code in the process, when it is not only unnecessary,
> but IMO makes the code less flexible.

I guess we are past the point where I explain that all I did was remove 
a lot of duplicate code :-)  I.e. it would not be productive to argue 
about that any further.

[]
> I won't reply to the rest of what you wrote because, as I hope I've
> made clear, I do not feel it has any bearing on this discussion.

What about this patch to finalize the effect-defaults for 'Inactive' being 
the same as the normal colors?

Index: kdeui/colors/kcolorscheme.cpp
===================================================================
--- kdeui/colors/kcolorscheme.cpp       (revision 712618)
+++ kdeui/colors/kcolorscheme.cpp       (working copy)
@@ -87,7 +87,7 @@
         _effects[Contrast]  = cfg.readEntry(  "ContrastEffect", (int)ContrastFade );
         _amount[Intensity]  = cfg.readEntry( "IntensityAmount", 0.0 );
         _amount[Color]      = cfg.readEntry(     "ColorAmount", 0.0 );
-        _amount[Contrast]   = cfg.readEntry(  "ContrastAmount", 0.7 );
+        _amount[Contrast]   = cfg.readEntry(  "ContrastAmount", state == QPalette::Disabled ? 0.7 : 0.0 );
         if (_effects[0] >= ColorFade)
             _color = cfg.readEntry( "Color", QColor(128, 128, 128) );
     }

An extra 'if' might be added to add changes in defaults for things like 
the highlights etc.

Cheers!
-- 
Thomas Zander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070915/25bef143/attachment.sig>