KPushButton::setDelayedMenu

Dominik Haumann dhdev at gmx.de
Thu Sep 6 18:14:16 BST 2007


On Thursday 06 September 2007, Thomas McGuire wrote:
> Hello,
>
> On Thursday 06 September 2007, Allen Winter wrote:
> > On Wednesday 18 July 2007 7:59:40 am Thomas McGuire wrote:
> > > Hi,
> > >
> > > On Saturday 07 July 2007, Dominik Haumann wrote:
> > > > KPushButton is pretty much broken with regard to the delayed menu
> > > > capabilities. As QPushButton::setMenu is not virtual there is an
> > > > additional function KPushButton::setDelayedMenu().
> > > >
> > > > When you hold down the button long enough a timer ticks which then
> > > > adds the menu by using QPushButton::setMenu(delayed_menu).
> > > >
> > > > That's also the reason why KPushButton does not show the "down
> > > > arrow" on the right side of the button even if you set a delayed
> > > > menu. The arrow is shown when you hold down the button long enough.
> > > > That means that there is no indication that the button has a
> > > > delayed menu at all.
> > >
> > > I tried your patch because I had hopes that it would fix the arrow
> > > that are not shown for toolbar buttons which have a menu. Examples of
> > > these are the file selection dialog, which has a configure button, or
> > > KMail's check mail, reply and forward buttons.
> > >
> > > However, they are still the same, so they either don't use
> > > KPushButton or something went wrong with the patch.
> > >
> > > It is important that the arrow is shown in this case, otherwise the
> > > user will never discover the functionality.
> > >
> > > > I'm sorry for not providing a proper .patch file, but I've locally
> > > > change the file in other places as well ;)
> > >
> > > Anyway, I've made a patch out of it. See attached.
> > >
> > > Hopefully someone will have a look at this patch and at the toolbar
> > > arrow issue.
> >
> > Was this issue ever resolved?
> > I don't see anything that resembles Thomas' patch in kpushbutton.cpp
>
> Well, I just took Dominik's patch and made a diff file out of it. I was
> hoping that it would fix the missing arrows in toolbar buttons, but that
> was a completely different issue.

Btw, regarding the down-arrow in toolbars: has that anything to do with 
KPushButton? Are KPushButtons used in toolbars? Afaik not. ;)

So maybe there is more that just the KPushButton issue.

> I have no idea at all about this patch, sorry.
>
> Regards,
> Thomas




More information about the kde-core-devel mailing list