API change request

Alex Merry huntedhacker at tiscali.co.uk
Sat Sep 1 16:42:30 BST 2007


I'd like to change the KScanDialog and KOCRScanDialog constructors to 
take two more arguments, in line with KPluginFactory.  This means that 
those values can then be passed to the KPluginFactory constructors.

Attached is the diff for kdelibs/kio/kio/kscan.{h,cpp}

This is needed to make libkscan (the implementation of KScanDialog, 
contained in kdegraphics) a proper new-style plugin.  I'll obviously 
patch libkscan at the same time.

LXR shows that only libkscan is using KScanDialogFactory (and libkscan 
currently doesn't work, but I can make it at least load with this 
change).

I'll commit on Monday if no-one objects.

Alex


-- 
KDE: http://www.kde.org
Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kscan.diff
Type: text/x-diff
Size: 3014 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070901/13436edb/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070901/13436edb/attachment.sig>


More information about the kde-core-devel mailing list