Status of konqueror / dolphin as file manager

Peter Penz peter.penz at gmx.at
Tue Oct 30 21:30:16 GMT 2007


Hi Matthew,

On Tuesday, 30. October 2007 22:11, Matthew Woehlke wrote:
> I've got a worse one... using Selection::NormalBackground for the 'extra
> info' text in icon view. This is violating not one, but two HIG rules:
>
> - do not use background colors to draw text
> - do not mix color sets
>
> This breaks in quite a few cases. This needs to use one of the extra
> foreground roles instead. Specifically this looks like it should be
> using View::InactiveText (and of course Selection::InactiveText when
> selected).
>
> (Anyone know where the code for this is? I'd take a crack at fixing it,
> but I didn't find it...)

It's in kdelibs/kio/kio/kfileitemdelegate.cpp. Please take care giving Fredrik 
a note when you do changes in this class (see CC). If I can help somewhere, 
just let me know...

Thanks :-)
Peter




More information about the kde-core-devel mailing list