[PATCH] KConfig code cleanups

Thomas Braxton kde.braxton at gmail.com
Sat Oct 27 23:07:10 BST 2007


Attached is a patch that cleans up some of the code in kdecore/config and
adds a bunch of assertions to KConfigGroup. No feature changes. ok to
commit?

A couple of other things I would like to ask about:
1) do we want to support an empty group name? We've never supported it
before, and I really don't see a use for it, but it shouldn't be too hard to
add support for.
1a) If we do, do we want to support empty sub-group names?
2) this one depends on #1, should the name of the default group be exposed?
It's really just an implementation detail that I think should never be
returned to the user, unless we decide to support empty group names.
3) should the translated entries from other locales be removed from the
entryMap? IIRC the reason I left them in was because of an idea to allow
changing of the locale without having to call reparseConfiguration, but I
now think that wasn't a good idea and it was never fully implemented, so
they shouldn't be in the entryMap.

Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071027/4c42f660/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanups.diff
Type: application/octet-stream
Size: 25951 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071027/4c42f660/attachment.obj>


More information about the kde-core-devel mailing list