[PATCH] Kickoff+Logout = Hangs

[Robert Knight]

Hi,

> P.S.: I know this const_cast is ugly, however I'd blame the API here,
> because making a 'openUrl' method const is a bad design IMHO...

My mistake there.  Fixing the problem at source (as per Aaron's
change) is preferable to hacking around it.

The only other comment I have is that the prefix for member variables
should be m_ ( m_url ).

Regards,
Robert.

On 26/10/2007, Aaron J. Seigo <aseigo at kde.org> wrote:
> On Friday 26 October 2007, Tobias Koenig wrote:
> > when you try to close the KDE4 session with kickoff the logout
>
> thanks for looking into this...
>
> > Attached is a patch which does that. Ok for commit?
>
> mico-nitpick: perhaps instead of storing the whole QUrl and doing the
> path().remove("/") again (just seems a bit brittle having that in more than
> one place if things change elsewhere in the code?), maybe just have a
> QString
> logoutAction member in the class. or even a slot for each of the possible
> actions and no QString member, though that's probably more work than it's
> worth.
>
> in any case, i'm cool with the patch in general.
>
> > P.S.: I know this const_cast is ugly, however I'd blame the API here,
> > because making a 'openUrl' method const is a bad design IMHO...
>
> i've made openUrl non-const now ...
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Trolltech
>