[patch] Re: kconfiggroup template 'mess'

Thomas Braxton kde.braxton at gmail.com
Thu Oct 25 20:31:41 BST 2007


On 10/25/07, Oswald Buddenhagen <ossi at kde.org> wrote:
>
> On Thu, Oct 25, 2007 at 05:06:22PM +0200, Jaroslaw Staniek wrote:
> > Attached a patch with explicit overloads and changes recommended by
> > Thiago (e.g. readEntryTemplate()).
> >
> note that prior to the first kconfig merge the api was also using
> templates and overloading them with non-templates. so this can't be a
> problem per se.
>
> > Tested on gcc 3.3.5 and msvc.
> > Can we start with this and polish it a bit?
> >
> i'm not impressed. major ugliness as a tribute to redmond.
> would you mind being *very* explicit about every problem you are
> encountering and elaborate on the cause? dropping cumulative patch-bombs
> with the comment "it works now, didn't do before" isn't helpful.


I have to agree, the only changes to kconfiggroup.h in the last couple of
weeks was changing some non-template overloads to template overloads, and
adding readListCheck/writeListCheck. So if you're having problems now, then
it is probably somewhere in those functions. Since I don't use either of
those compilers I can't help you much more than that.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071025/c0034fa0/attachment.htm>


More information about the kde-core-devel mailing list