[PATCH 2] Re: Missing Clear entry in context menu for lineedit
Jakob Petsovits
jpetso at gmx.at
Thu Oct 25 10:13:34 BST 2007
On Wednesday, 24. October 2007, Andras Mantia wrote:
> Hi,
>
> updated patch follows:
> - uses KStandardAction::clear
> - names the action Clear
> - puts it after Delete, like in KDE3
>
> If no objections, I will commit.
No objections from my side, but it would be great if you could adapt some
things before committing to more closely follow the official kdelibs coding
style ( http://techbase.kde.org/Policies/Kdelibs_Coding_Style ).
That is,
* braces for "if (toPlainText().isEmpty())" and "if (text().isEmpty())"
* consistent spacing: whitespace on the outside for "if( !isReadOnly() )"
and a space between "for" and the parenthesis
* no unnecessary whitespace after "actionIt++;"
and "clearAllAction->setEnabled(false);".
Only minor nitpicking, sorry for that ;)
(I would have skipped this mail if it wasn't for having braces for all ifs.)
Nice work,
Jakob
More information about the kde-core-devel
mailing list