KDE/kdelibs/kdeui/icons

[Jos Poortvliet]

On 10/16/07, Riccardo Iaconelli <riccardo at kde.org> wrote:
> On Tuesday 16 October 2007 19:59:59 Rafael Fernández López wrote:
> > KIconLoader now returns more quality icons if the requested size is not a
> > standard one. This means that if the size requested is not standard it will
> > try to load the icon from the SVG format before than trying to load the PNG
> > image and then resizing it (what leads to a worse image quality). In the
> > case that not SVG was found and PNG was, the change on KIconTheme assures
> > that it will stop on the closest size bigger than the selected (for
> > example, it will stop on 22x22 if you requested a 19x19 pixels icon size)
> > and then resize it. This will only happen if the SVG wasn't found. If the
> > size is a standard one, go on with the normal procedure: load the PNG that
> > is faster than drawing a SVG and since no resizes are needed no quality is
> > lost.
>
> Please revert this patch. It leads to uncorrect renderings (e.g. the KDE logo
> will look like in the KDE 4 mousepad shipped at akademy).

I guess an important question is: what looks worse, an upscaled PNG or
a slightly broken SVG? (note I have no idea, but I thought it should
be asked)

> Bye,
> -Riccardo
> --
> GPG key:
> 3D0F6376
> When encrypting, please encrypt also for this subkey:
> 9EBD7FE1
> -----
> Pace Peace Paix Paz Frieden Pax Pokój Friður Fred Béke 和平
> Hasiti Lapé Hetep Malu Mир Wolakota Santiphap Irini Peoch
> Shanti Vrede Baris Rój Mír Taika Rongo Sulh Mir Py'guapy 평화
>