KToolBar api cleanup

Martin Pley kde-core at pley.org
Mon Oct 15 21:53:54 BST 2007


Hi,

> KConfigGroup usage in KToolBar is weird, it has kde3 logic like "if group
> name is empty then set it to some group name made up by ktoolbar".
>
> I checked KDE+extragear+playground with lxr and with gcc:
> 1) the few calls to saveSettings+applySettings do pass a group name, which
> is of course the only sensible thing to do with KConfigGroup;
> 2) protected settingsGroup() was only used internally (and only for the
> fallback group thing) -> removed 3) protected applyAppearanceSettings() is
> only used internally -> made private
>
> Patch attached (normally I would have just committed, but well, let's play
> by the rules ;)

if I see it correctry, you may make "KConfigGroup &"-parameter const within 
applyAppearanceSettings

Kind regards
Martin Pley





More information about the kde-core-devel mailing list