Warning in acinclude.m4.in / KDE branch 3.5
David Faure
faure at kde.org
Mon Oct 15 18:17:45 BST 2007
On Monday 15 October 2007, Michael Pyne wrote:
> On Monday 15 October 2007, Martin Pley wrote:
> > Hi,
> >
> > I get a warning within libz-check with gcc 4.2.1 on SuSE 10.3. If there are
> > no complaints about it, i'd like to commit the following patch:
> >
> snip
> > @@ -2638,7 +2639,7 @@
> > /* this would segfault.. but we only link, don't run */
> > (void) gzgets(f, buf, sizeof(buf));
> >
> > - return (zlibVersion() == ZLIB_VERSION);
> > + return (strcmp(zlibVersion(), ZLIB_VERSION) == 0);
>
> Patch looks good to me (apparently both the function and the macro use
> strings, go figure). Someone with more magic than myself would have to
> commit it though.
Committed.
--
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel
mailing list