Warning in acinclude.m4.in / KDE branch 3.5

Michael Pyne michael.pyne at kdemail.net
Mon Oct 15 18:07:54 BST 2007


On Monday 15 October 2007, Martin Pley wrote:
> Hi,
>
> I get a warning within libz-check with gcc 4.2.1 on SuSE 10.3. If there are
> no complaints about it, i'd like to commit the following patch:
>
snip
> @@ -2638,7 +2639,7 @@
>    /* this would segfault.. but we only link, don't run */
>    (void) gzgets(f, buf, sizeof(buf));
>
> -  return (zlibVersion() == ZLIB_VERSION);
> +  return (strcmp(zlibVersion(), ZLIB_VERSION) == 0);

Patch looks good to me (apparently both the function and the macro use 
strings, go figure).  Someone with more magic than myself would have to 
commit it though.

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071015/59798142/attachment.sig>


More information about the kde-core-devel mailing list