KConfig and $HOME

Thomas Braxton kde.braxton at gmail.com
Sat Oct 13 15:55:56 BST 2007


On 10/12/07, Thomas Braxton <kde.braxton at gmail.com> wrote:
>
>
>
> On 10/12/07, Allen Winter <winter at kde.org> wrote:
> >
> > On Friday 12 October 2007 3:00:43 pm Thomas Braxton wrote:
> > > On 10/12/07, Oswald Buddenhagen <ossi at kde.org> wrote:
> > > >
> > > > On Fri, Oct 12, 2007 at 11:50:30AM -0400, Allen Winter wrote:
> > > > > 1) support reading environment variables with or without the [$e]
> > > > > 2) support writing environment variables only with the [$e]
> > > > >
> > > > most definitely not. variables were never just expanded.
> > > > we are talking exclusively about {read,write}PathEntry(), for which
> > > > $HOME/ at the beginning is sort of a magic token. i don't think it
> > makes
> > > > much sense to change that behavior in any way.
> > > > and btw, this means that if somebody uses a $e path entry, he has to
> > > > write it $$HOME/... in the ini file.
> > >
> > >
> > > Sorry I just checked my mail, I want to make sure exactly what we want
> > here
> > > so I can fix it tommorrow. It looks like we want to convert $HOME/
> > anytime
> > > readPathEntry is used even if there is no [$e], is this right?
> > >
> > Yes, that is how ossi explained it to me.
> >
> No problem, should only be a 1 or 2 line change, but I can't do anything
> until tomorrow.


here's a patch that fixes readPathEntry, and a patch for  kconfigtest, is
this good?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071013/61440069/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: home-fix.diff
Type: application/octet-stream
Size: 725 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071013/61440069/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kconfigtest.diff
Type: application/octet-stream
Size: 1089 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071013/61440069/attachment-0001.obj>


More information about the kde-core-devel mailing list