[PATCH] Use natural sorting in KUrlNavigator popup

Aurélien Gâteau aurelien.gateau at free.fr
Thu Oct 11 23:41:53 BST 2007


Allen Winter wrote:

> On Thursday 11 October 2007 5:59:01 pm Aurélien Gâteau wrote:
>> Hello,
>> 
>> I noticed the KUrlNavigator popup currently display items in plain
>> alphabetic-case sensitive order. Attached patch use naturalCompare from
>> KDirSortFilterProxyModel to sort the list in natural order.
>> 
>> I also moved the sort to the listJobFinished() method, since there is no
>> need to sort the list every time we receive entries.
>> 
>> Is it ok to commit?
>> 
> Should KDirSortFilterProxyModel::naturalCompare() be moved
> someplace a little more general purpose?
> 
> Seems like a very useful method that could be used in many
> different places throughout KDE... not that anything comes
> quickly to mind.

I agree. Maybe we can move it to KStringHandler. What do you think about
this?

Aurélien





More information about the kde-core-devel mailing list