KConfig/KLockFile performance (was KMimeType performance)

Thomas Braxton kde.braxton at gmail.com
Tue Oct 9 20:22:06 BST 2007


On 10/9/07, David Faure <faure at kde.org> wrote:
>
> On Tuesday 09 October 2007, Maksim Orlovich wrote:
> > KDesktopFile/KConfig tries to lock the file with KLockFile
>
> Huh. I thought we got rid of the "bool readonly" because it made no
> behavior difference,
> but if KConfig locks the file then surely we need a "ReadOnly" flag again?
> Or better: we should lock at the time of writing to the file, not when
> just reading from it!


your mail came in as I was sending the last patch, here's another try. this
time only locking in sync() and only if the file is read-write.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071009/a31d786b/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config-lock-fix-try2.diff
Type: application/octet-stream
Size: 1745 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071009/a31d786b/attachment.obj>


More information about the kde-core-devel mailing list