KConfig/KLockFile performance (was KMimeType performance)

[Thomas Braxton]

On 10/9/07, Thiago Macieira <thiago at kde.org> wrote:
>
> Em Tuesday 09 October 2007 19:45:47 Maksim Orlovich escreveu:
> > The problem here isn't really KMimeType. What happens is that
> > KFolderMimeType looks for a .directory file to get a comment, and uses a
> > KDesktopFile to read that. KDesktopFile/KConfig tries to lock the file
> > with KLockFile. KLockFile can't, no permissions in /usr/include, so it
>
> It shouldn't be locking a file that it can't write to anyways.


you're right, I haven't had a chance to go back and look at lock() yet,
that's probably what was causing all those "can't lock local file" warnings
also. Does this patch fix it?

And it should be considered an "administration error" to modify a shared
> file
> while it's in use. (That's why there are tools like vipw to edit
> /etc/passwd
> and save it atomically)
>
> --
> Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
>   PGP/GPG: 0x6EF45358; fingerprint:
>   E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071009/3ae7c129/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: config-lock-fix.diff
Type: application/octet-stream
Size: 1338 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071009/3ae7c129/attachment.obj>