list separator in config entries

Andreas Hartmetz ahartmetz at gmail.com
Mon Oct 8 19:24:48 BST 2007


2007/10/8, Andreas Pakulat <apaku at gmx.de>:
> On 08.10.07 20:02:54, Andreas Hartmetz wrote:
> > 2007/10/8, Andreas Pakulat <apaku at gmx.de>:
> > > On 08.10.07 08:09:26, Thomas Braxton wrote:
> > > Uhm, we can't change the API after 4.0, so removing the custom-separator
> > > method is needed to be done _now_.
> > >
> > Fortunately, a random sampling of about 25 of lxr.kde.org's 170 hits
> > for "readEntry" didn't turn up one single user of custom separators.
> > It's totally silly, and API users seem to have realized it :)
>
> Oops missed the readEntries. So here's the combined result:
>
> andreas at morpheus:~/KDE-work/4.0>find kdebase/ kdegraphics/ kdegames/ kdemultimedia/ kdenetwork/ kdepimlibs/ kdesdk/ kdeutils/ kdevelop kdevplatform/ -name \*.cpp -or -name \*.h | xargs grep "\(read\|write\)Entry([^,]\+,[^,]\+,[ ]*'"
> kdebase/runtime/kioslave/media/libmediacommon/notifierserviceaction.cpp:        desktopGroup.writeEntry(QString("ServiceTypes"), m_mimetypes, ',');
> kdebase/workspace/kcontrol/kxkb/kxkbconfig.cpp: displayNamesList = config.readEntry("DisplayNames", displayNamesList, ',');
> kdebase/workspace/kicker/applets/media/mediaapplet.cpp:         mExcludedTypesList = c.readEntry("ExcludedTypes",QStringList(),';');
> kdebase/workspace/kicker/applets/media/mediaapplet.cpp:         mExcludedList = c.readEntry("ExcludedMedia",QStringList(),';');
> kdebase/workspace/kicker/applets/media/mediaapplet.cpp: c.writeEntry("ExcludedTypes", mExcludedTypesList, ';');
> kdebase/workspace/kicker/applets/media/mediaapplet.cpp: c.writeEntry("ExcludedMedia", mExcludedList, ';');
> kdebase/apps/konqueror/settings/filetypes/typeslistitem.cpp:    cg.writeEntry("Patterns", m_patterns, ';');
> kdebase/apps/konqueror/settings/filetypes/typeslistitem.cpp:            ? (*s_changedServices)[ pService->entryPath() ] : group.readEntry("MimeType",QStringList(), ';');
> kdebase/apps/konqueror/settings/filetypes/typeslistitem.cpp:          group.writeEntry("MimeType", mimeTypeList, ';');
> kdebase/apps/konqueror/settings/filetypes/typeslistitem.cpp:            ? (*s_changedServices)[ pService->entryPath() ] : group.readEntry("MimeType", QStringList(),';');
> kdebase/apps/konqueror/settings/filetypes/typeslistitem.cpp:      group.writeEntry("MimeType", mimeTypeList, ';');
> kdegames/kshisen/app.cpp:                       QStringList e = group.readEntry(s,QStringList(), ' ');
> kdenetwork/lanbrowsing/kcmlisa/kcmlisa.cpp:   m_pingNames->insertStringList(m_config.group("").readEntry("PingNames",QStringList(),';'));
> kdenetwork/lanbrowsing/kcmlisa/kcmlisa.cpp:      m_config.group("").writeEntry("PingNames",writeStuff,';');
> kdesdk/kate/plugins/filebrowser/katefileselector.cpp:  setupToolbar( fileselectorConfigGroup.readEntry( "toolbar actions", QStringList(), ',' ) );
> kdesdk/kate/plugins/filebrowser/katefileselector.cpp:  QStringList l = config.readEntry( "toolbar actions", QStringList(), ',' );
> kdesdk/kate/plugins/filetemplates/plugin/filetemplates.cpp:  cg.readEntry( "Hidden", hidden, ';' );
> kdesdk/kate/plugins/filetemplates/plugin/filetemplates.cpp:      cg.readEntry( "Hidden", l, ';' );
> kdesdk/kate/plugins/filetemplates/plugin/filetemplates.cpp:      cg.writeEntry( "Hidden", l, ';' );
> kdesdk/kcachegrind/kcachegrind/configuration.cpp:  sourceConfig.writeEntry("Dirs", c->_generalSourceDirs, ':');
> kdesdk/kcachegrind/kcachegrind/configuration.cpp:  dirs = sourceConfig.readEntry("Dirs", QStringList(),':');
> kdesdk/kcachegrind/kcachegrind/configuration.cpp:    dirs = sourceConfig.readEntry(QString("Dirs%1").arg(i), QStringList(),':');
> kdeutils/superkaramba/src/themelocale.cpp:    //languageList += config->readEntry("Language", QStringList(), ':');
>
Yo, most of them are specifying the tentative new default anyway and
some even the old default.  Looks like the only problem would be a BIC
change and the need to upgrade config files from 3 to 4, which most
apps will need anyway. KConfig has already changed.




More information about the kde-core-devel mailing list