[Patch] KUrl::prettyUrl and xmpp: url

David Faure faure at kde.org
Sun Oct 7 22:22:20 BST 2007


On Sunday 07 October 2007, Olivier Goffart wrote:
> Hi,
> 
> So since we are in a freeze, I send patches to this list.
> The patch is pretty simple, but I'm not sure of possible side effect.
> 
> In Konqueror, if you have a link such as, 
> <a href="xmpp:foo at bar.com"> , it is modified to xmpp://foo@bar.com
> xmpp: and xmpp:// have very different meaning, and the most common use is 
> xmpp:
> 
> The attached path fixes the issue.
>
> I've made a special case for file: because tests seems to require file:/// 
> I don't know the logic behind this.
Different interpretations of the URL spec by different people.... don't ask :)

> Ok to commit ?
I assume kurltest still passes without failure, so yes. If anything breaks it'll be
the fault of a missing unit test ;) (but kurltest is pretty extensive).

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list