KFileTreeView almost fixed - STRANGE STUFF

David Faure faure at kde.org
Thu Nov 29 10:47:19 GMT 2007

On Thursday 29 November 2007, Rafael Fernández López wrote:
> Hi,
> With the attached patch kdelibs/kfile/tests/kfiletreeviewtest runs nicely and 
> without problems.
> OK to commit ?

Looks good, thanks.

Minor performance note: I would call mapFromSource only once and put the result in a local QModelIndex variable:
+    selectionModel()->setCurrentIndex(d->pModel->mapFromSource(index), QItemSelectionModel::SelectCurrent);
+    scrollTo(d->pModel->mapFromSource(index));

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list