[PATCH] Drop on places selector to bookmark

Aurélien Gâteau aurelien.gateau at free.fr
Wed Nov 28 13:01:04 GMT 2007

Aurélien Gâteau wrote:

> Kevin Ottens wrote:
>> Le mardi 27 novembre 2007, Aurélien Gâteau a écrit :
>>> Attached patch makes it possible to add new places to the places
>>> selector (the folder icon on the left of the url navigator widget) by
>>> dropping urls on it. It's handy when used in an app which does not have
>>> a KFilePlacesView widget or when this widget is hidden.
>> Looks fine to me, except this bit:
>> +     const KUrl::List urlList =
>> KUrl::List::fromMimeData(event->mimeData());
>> +     if (urlList.isEmpty()) {
>> +             return;
>> +     }
>> It uses tabs instead of spaces for indenting. Also, you can probably use
>> foreach() instead of Q_FOREACH() (I know it's personal taste but it's
>> more readable, and that's not as if it was in a public header).
>> I really like the overall idea.
> Great, attached is an updated patch.

I just committed it.


More information about the kde-core-devel mailing list