[PATCH] Drop on places selector to bookmark

Kevin Ottens ervin at kde.org
Tue Nov 27 10:05:20 GMT 2007

Le mardi 27 novembre 2007, Aurélien Gâteau a écrit :
> Attached patch makes it possible to add new places to the places selector
> (the folder icon on the left of the url navigator widget) by dropping urls
> on it. It's handy when used in an app which does not have a KFilePlacesView
> widget or when this widget is hidden.

Looks fine to me, except this bit:
+	const KUrl::List urlList = KUrl::List::fromMimeData(event->mimeData());
+	if (urlList.isEmpty()) {
+		return;
+	}

It uses tabs instead of spaces for indenting. Also, you can probably use 
foreach() instead of Q_FOREACH() (I know it's personal taste but it's more 
readable, and that's not as if it was in a public header).

I really like the overall idea.

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071127/8170508a/attachment.sig>

More information about the kde-core-devel mailing list