gcc -Woverloaded-virtual

[Olivier Goffart]

Le lundi 26 novembre 2007, David Faure a écrit :
> On Sunday 25 November 2007, Aurélien Gâteau wrote:

> > A better fix IMO would be to get rid of (1), make (2) not inherit meta
> > data and add a method like this:
> >
> >     void mergeMetaDataFromJob(KJob* job)
> >
> > But it means all code which relies on KIO::Job::addSubjob() merging meta
> > data needs to be fixed.
>
> This is out of the question IMHO. Merging was =true by default, so it
> should happen by default, because it's the most likely case. If it's not
> done automatically people will forget to call mergeMetaData for sure.


Maybe the opposite : something like
void addJobWithoutMerge(KJob *job)

So we will use the compile error to help us to port. 
This is also better API than using a meaningless bool.

The only problem is the freeze :-)

 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071126/3d74df21/attachment.sig>