[PATCHes] Re: even more on kconfig escapes (Re: KDE/kdelibs/kdeui/icons)

[Thomas Braxton]

On 11/23/07, Oswald Buddenhagen <ossi at kde.org> wrote:
> On Fri, Nov 23, 2007 at 05:22:05PM +0100, Andreas Pakulat wrote:
> > On 22.11.07 21:02:24, Oswald Buddenhagen wrote:
> > > next would be adding a backwards compatible group name parser and
> > > related logic. but somebody with authority has to prod me into doing it.
> > > ;)
> >
> > Out of curiosity: What types of group names from old configs (especially
> > kde3) can now not be parsed anymore (or parsed incorrectly)?
> >
> [this is [[ a ]] test] (means "this is [ a ] test").
> conversely, kde3 won't be able to read [this is \x5b a \x5d test].
>
> > > +++ b/tests/kconfigtest.cpp
> > > +#define SUBGROUPLIST (QStringList() << "SubGroup/3" << "SubGroup1" << "SubGroup2")
> >
> > I'm wondering if there's a way to make this constant and the test
> >
> > >      QCOMPARE(cg.groupList(), SUBGROUPLIST );
> >
> > a bit more reliable. Currently the test relies on whatever order the
> > kconfig backend decides to use to write out the groups, but I think
> > that it shouldn't.
> >
> indeed.
> not that it is a real problem - the order is known to be alphabetical
> and if it changes, we can adapt the test.

as long as KEntryMap is a map, then the order can't change unless
someone changes operator<(const KEntryKey&, const KEntryKey&)

> > Maybe we should use QSet::fromList() around the groupList and compare
> > to a QSet?
> >
> most probably.
>
> --
> Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
> --
> Chaos, panic, and disorder - my work here is done.
>