[PATCH]KConfigGroup::groupList() kind of broken

Thomas Braxton kde.braxton at gmail.com
Tue Nov 20 08:27:45 GMT 2007


On 11/19/07, Andreas Pakulat <apaku at gmx.de> wrote:
> On 20.11.07 00:56:34, Oswald Buddenhagen wrote:
> > On Tue, Nov 20, 2007 at 12:13:01AM +0100, Andreas Pakulat wrote:
> > > On 19.11.07 23:58:17, Oswald Buddenhagen wrote:
> > > > On Mon, Nov 19, 2007 at 11:36:48PM +0100, Andreas Pakulat wrote:
> > > > > I'm not sure wether name() should be changed now and then a new function
> > > > > added to KConfigGroup in 4.1... Opinions?
> > > > >
> > > > good idea, also precludes silent failures.
> > >
> > > So are you saying we should change name() now to make sure we don't get
> > > silent failures later on and introduce a new function for KDE 4.1?
> > >
> > yes. well, once everything is compiled and some time has passed, one can
> > add the new function. it's just going to be 4.1 at that time, quite
> > probably.
>
> Ok, while implementing this I've found a new problem :(
>
> KConfigGroup bargrp( &grp, "foo/bar" );
>
> returns "foo/bar" as name, though implementation wise that group is the
> same as bargrp here:
>
> KConfigGroup middle(&grp, "foo");
> KConfigGroup bargrp(&middle, "bar");
>
> That made the implementation a bit more costly, though I guess we can't
> fix this without creating a real parent-child relation ship between
> KConfigGroups, instead of just handling group names in a special way.
>
> Updated patch attached, unless I hear screams from anybody I'm going to
> commit this tomorrow around this time.

just one question. if you have two groups [group1/subgroup] and
[group2/subgroup] with your changes to name() both return "subgroup"
how do you know which one you are working with?

> > > If just kdevelop3 would be a bit better at working with kdelibs...
> > >
> > you mean, like not crashing every 10 minutes or eating 100% cpu? :-P
>
> :)
>
> Actually I just mean being a bit faster at opening and working with
> kdelibs, though I didn't try kdelibs for a long time now. About the 100%
> cpu, make sure you don't use 3.5.0 (but latest from KDE/3.5/kdevelop)
>
> Andreas
>
> --
> Troubled day for virgins over 16 who are beautiful and wealthy and live
> in eucalyptus trees.
>
>




More information about the kde-core-devel mailing list