[PATCH] Only show tabs in kpluginselector config dialogs when needed

Aaron J. Seigo aseigo at kde.org
Mon Nov 19 17:56:02 GMT 2007

On Monday 19 November 2007, Will Stephenson wrote:
> On Monday 19 November 2007, Aaron J. Seigo said:
> > not sure if it's worth it, but it does also prevent a second run through
> > the list. *shrug*
> Nice idea, here's the implementation.  It looks really scary if the
> reparented widget isn't addTabbed to the tabwidget, though.  

no attachment, so i'll just imagine it *imagines* wow! it's great! ;)

> The one other thing to do would be to change the content margins on widgets
> when they are inserted in single mode. 

tbh, the container should supply the margin and config pages should never have 
their own margins. this is for the reason you just stated: the plugin never 
knows where it might be shown, only the contain can know that.

there is setContentsMargins now in Qt4 which is pretty darned handy in these 
situations as well..

Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071119/bdbae8cf/attachment.sig>

More information about the kde-core-devel mailing list