[PATCH] Only show tabs in kpluginselector config dialogs when needed

Will Stephenson wstephenson at kde.org
Mon Nov 19 17:52:08 GMT 2007

On Monday 19 November 2007, Aaron J. Seigo said:
> not sure if it's worth it, but it does also prevent a second run through
> the list. *shrug*

Nice idea, here's the implementation.  It looks really scary if the reparented 
widget isn't addTabbed to the tabwidget, though.  I've tested this in single 
and tabbed mode by hacking Kopete to install some extra .desktop files for 
some plugins.

The one other thing to do would be to change the content margins on widgets 
when they are inserted in single mode.  At the moment the Kopete plugin 
config widgets have fat borders to make them look nice in a tabwidget.  We 
could change this statically in the config widgets themselves, but that is a 
bit of a shame because the widget doesn't know how what it is being parented 
into.  But no white magic occurs to me as the KCModuleProxy is deliberately 

> out of curiosity, does the currentModuleProxy object get deleted if it
> isn't a realModule()? does it matter?

I'm not thinking about that now :).


More information about the kde-core-devel mailing list