need BIC and SIC change to phonon

Matthias Kretz kretz at kde.org
Fri Nov 16 12:40:42 GMT 2007


Hi,

I need to fix an interface class for the phonon backends:
VolumeFaderInterface has a slightly different function signature as does 
EffectInterface. As backend implementations for VolumeFaderInterface have to 
inherit EffectInterface anyway, the two functions need to simply be removed 
from the VolumeFaderInterface.

--- volumefaderinterface.h      (revision 737258)
+++ volumefaderinterface.h      (working copy)
@@ -37,12 +37,9 @@
         }
         virtual void setFadeCurve(Phonon::VolumeFaderEffect::FadeCurve) {}
         virtual void fadeTo(float, int) {}
-        virtual QVariant parameterValue(int) const { return QVariant(); }
-        virtual void setParameterValue(int, const QVariant &) {}
-
 };
 }

-Q_DECLARE_INTERFACE(Phonon::VolumeFaderInterface, "VolumeFaderInterface3.phonon.kde.org")
+Q_DECLARE_INTERFACE(Phonon::VolumeFaderInterface, "VolumeFaderInterface4.phonon.kde.org")

 #endif // PHONON_VOLUMEFADERINTERFACE_H


PS: I only found this error because I added -Woverloaded-virtual to my 
CXXFLAGS.

-- 
________________________________________________________
Matthias Kretz (Germany)                            <><
http://Vir.homelinux.org/
MatthiasKretz at gmx.net, kretz at kde.org,
Matthias.Kretz at urz.uni-heidelberg.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071116/8359d051/attachment.sig>


More information about the kde-core-devel mailing list