Documentation patch for kdeui/dialogs/kedittoolbar.h

David Faure faure at kde.org
Thu Nov 15 15:26:26 GMT 2007


On Monday 12 November 2007, Albert Astals Cid wrote:
> It adds two changes, actually you seldom need to use kedittoolbar at all since 
> setupGUI does it all for you, except in the case of using plugListAction, 
> that you need to replug the actions again.
> 
> Is this patch ok to be included?

I was surprised by the documentation change. 

@@ -62,9 +77,9 @@
  *
  * void MyClass::slotNewToolBarConfig() // This is called when OK, Apply or Defaults is clicked
  * {
- *    ...if you use any action list, use plugActionList on each here...
  *    createGUI();
  *    applyMainWindowSettings( KGlobal::config(), "MainWindow" );
+ *    ...if you use any action list, use plugActionList on each here...
  * }
  * \endcode

but it turns out that it's correct, non-kparts-mainwindows should do createGUI + plugActionList + applyMainWindowSettings
(yeah I would do it in that order, moving toolbars before adding all actions to them seems strange).

In konqueror and koffice and other kparts mainwindows, it's simply plugActionList + applyMainWindowSettings.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list