[PATCH] kdelibs/kdeui/kdatepicker.cpp

John Layt johnlayt at yahoo.com.au
Thu Nov 8 23:13:25 GMT 2007

On Thursday 08 November 2007, Aaron J. Seigo wrote:
> On Wednesday 07 November 2007, John Layt wrote:
> > OK to commit?
> the code looks right upon careful reading of it[1], but i'm far from
> familiar with the internals of this class. are there unit tests for these
> issues that can go along with the fixes to both prevent regressions as well
> as prove these things work? =)
> [1] took a moment for me to see that weekYear was getting passed in by
> reference to a method that is in an i18n statement. =) might be worth a
> commentin the code there noting the dual purpose of the next line? *shrug*

Reworked patch attached with better comments and clearer workings.

At the moment, the unit test consists of running 
kdecore/kdeui/tests/kdatepicktest and manually selecting dates, then manually 
comparing to the KDE3 version.  Proper unit tests are planned for 4.1.



P.S. D'oh, just remembered about the kdelibs-bugs list...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdatepicker-fillweekscombo-take2.diff
Type: text/x-diff
Size: 15205 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071108/c0c063f5/attachment.diff>

More information about the kde-core-devel mailing list