[PATCH] kdelibs/kdeui/kdatepicker.cpp

[John Layt]

Have this one floating around from way back...


Problem: In a KDatePicker (e.g. run kdeui/tests/kdatepicktest), select year 
9999 or -4713 (i.e. max/min valid years), and it will infinite loop inside 
fillWeeksCombo().

Solution: Add checks to ensure loop start, end, and incremented dates are 
valid.


Problem: In fillWeeksCombo() if first week of year is week 53 of previous year 
(e.g. 2010, 9999), then all the weeks in the combo get incorrectly marked 
with '*' as being in a different year.

Solution: Re-initiaise the year variable each time through the loop.


OK to commit?

Cheers!

John.

--

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdatepicker-fillweekscombo.diff
Type: text/x-diff
Size: 3594 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071108/bc57b8b9/attachment.diff>