[patch] KConfig on windows/msvc, simplified

Jaroslaw Staniek js at iidea.pl
Tue Nov 6 23:45:50 GMT 2007

Oswald Buddenhagen said the following, On 2007-11-07 00:21:
> On Tue, Nov 06, 2007 at 10:56:19PM +0100, Jaroslaw Staniek wrote:
>> Uff. It's cleaned version of the patch, without part related to cleaning up 
>> of identifiers.
> thanks, that's much simpler to review.
> note that you still have some weird whitespace changes in there.

ok, but where's that?

> however, you entirely failed to respond to that:
>>> you also did another significant change: the read/write functions
>>> for the directly supported data types are no more template
>>> spcializations.
>>> i'm wondering how the changes behave when isolated from each other.

Depending which part of change you keep, with msvc you'll get errors related 
to QVariant internals or internal compiler's error.
The change is source compatible, except for qbytearray overloads (but usage of 
qbytearray keys came from the kconfig merge in 

regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice: http://www.kexi.pl/en, http://www.koffice.org
  KDE3 & KDE4 Libraries for MS Windows: http://kdelibs.com, http://www.kde.org

More information about the kde-core-devel mailing list