[PATCH]: KIconLoader::loadIcon() speed ups

Aaron J. Seigo aseigo at kde.org
Mon Nov 5 05:13:30 GMT 2007

On Sunday 04 November 2007, Aaron J. Seigo wrote:
> hi all..
> attached is a patch that rather dramatically improves the speed of
> KIconLoader::loadIcon().

i should also note that we're still doing one QImage -> QPixmap conversion in 
there when we don't get to hit the cache ... we ought to try and kill that as 
well one of these days.

there are 2 things that definitely still need it:

- the favicon overlay thing which is scanline based
- the effects

the svg rendering might also want it as it might be faster than the painting 
to a pixmap depending on how well the pixmap painter engine does.

with some additional care, we might be able to take out the image->pixmap 
conversion for the cases where there is no effect to be applied. this should 
further speed things up in the populating-the-cache scenario. granted, that's 
supposedly a one time cost, but it's still there to be paid.

Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071104/175af7f4/attachment.sig>

More information about the kde-core-devel mailing list