Solid API change request (with patch)

[Kevin Ottens]

Le jeudi 1 novembre 2007, Jeff Mitchell a écrit :
> The patch adds the device's udi to the signal, which makes it much
> simpler to figure out which device has had its accessibility changed.

A couple of things regarding your patch:

* line 10:
+        connect(dev.as<Solid::StorageAccess>(), 
SIGNAL(accessibilityChanged(bool, const QString &udi)),
should probably be:
+        connect(dev.as<Solid::StorageAccess>(), 
SIGNAL(accessibilityChanged(bool, const QString &)),

* The changes in solid/ifaces and solid/backends are probably unnecessary. The 
fact that we add the UDI should probably be a frontend only feature. At that 
point we could have enough information to provide this information... Granted 
the current organization would have to be slightly adapted in the frontend 
code. Maybe a cleanup for post-4.0...

* The change in the CMakeLists.txt is unwanted, but you already spotted that 
one.

Now, I'll also propose a change in a separate mail replying to sebas 
concerns. :-p

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071102/76b90016/attachment.sig>