libkdeprint

[Alex Merry]

On Wednesday 31 Oct 2007, John Layt wrote:
> Anyone have any feedback on this, particularly the Printer Name
> problem?  The sooner I can finish this and get it to Pino, the sooner
> I can move onto fixing the kcm :-)

Sorted.  Attached are the replacement fileprinter.* files, and the 
okular diff.

The problem was that "-P" and the printer name need to be seperate 
arguments (they are split up by bash).  All the option-creating methods 
now return QStringLists.  Which is why I suggested printing the 
QStringList arguments, because the echo command doesn't show the 
boundaries between arguments.

Additionally, I've removed the shell-quoting bits as there is no shell 
doing any interpreting.  I've also removed a bunch of explicit QString 
constructors where they are not needed (QString(const char *) is an 
implicit constructor).  And I've changed all the "foo != QString()" 
tests to "! foo.isEmpty()", which is more efficient.

Alex



-- 
KDE: http://www.kde.org
Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: okular.diff
Type: text/x-diff
Size: 21219 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071101/a2e47dd6/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fileprinter.cpp
Type: text/x-c++src
Size: 10687 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071101/a2e47dd6/attachment.cpp>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fileprinter.h
Type: text/x-c++hdr
Size: 5030 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071101/a2e47dd6/attachment.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20071101/a2e47dd6/attachment.sig>