[PATCH] RFC: Changing the language of individual KDE programs

[David Jarvie]

On Sunday 20 May 2007 20:49:01 Aaron J. Seigo wrote:
> On Saturday 19 May 2007, David Jarvie wrote:
> > On Tuesday 15 May 2007 09:05:29 Thomas Diehl wrote:
> > > I just received the following update on this more than 6 year old
> > > wishlist item with now 328 votes
> > > (http://bugs.kde.org/show_bug.cgi?id=24348). If this is true we won't
> > > see the requested feature in KDE 4.0 either:
> > >
> > > Well, the bug was essentially closed by Krzysztof Lichota (SVN commit
> > > 644712 http://websvn.kde.org/branches/KDE/3.5/kdelibs/?pathrev=647712)
> > > but his contribution was reverted for no new feature is allowed to the
> > > stable branch before it is implemented in trunk... and there seems to
> > > be nobody who'd will to be that... (see also some discussion in BR
> > > 103467 http://bugs.kde.org/show_bug.cgi?id=103467 )
> >
> > Attached is a patch to implement this function in trunk. Also required is
> > to move klanguagebutton.{h,cpp} back from
> > kdebase/runtime/kcontrol/locale/ into kdelibs/kdeui/widgets/.
>
> if that is going to happen, can we please have someone look at the API of
> that class. it's particularly horrible. there is nothing language specific
> in that class at all; it essentially a button that pops up a drop down with
> columnar data. the API seems to say otherwise in places, but it's really
> not true. it needs to be generalized to avoid being the red headed step
> child of kde libs.

I assume you're talking about KLanguageButton class. Are you complaining about 
the fact that it looks more like some sort of general combo box class rather 
than one designed to contain language name strings? In fact, most of the 
methods actually are language specific, but this fact is hidden by the apidox 
comments which don't make clear that the 'id' parameter which many of them 
take is actually a language code. If the apidox comments are improved, do you 
have any other objection to this class being moved to kdelibs?

-- 
David Jarvie.
KAlarm author and maintainer.
http://www.astrojar.org.uk/kalarm