Changes into KConfigSkeleton between kde3.x and kde4.0

Laurent Montel montel at kde.org
Wed May 16 22:00:07 BST 2007


Hi,
When I try to fix kbugbuster I see a bug into it.
KBugbuster used a KConfigSkeleton and when we close windowmanager we save 
config with "writeConfig();"
But it doesn't save data from KConfigSkeleton
because writeConfig function was changed between kde3.5 and kde4.0

Before it was:

KConfigSingleton::writeConfig()
{
....
   save_data_from_kconfigSingleton ;
....
   and after call: usrWriteConfig();
}

usrWriteConfig() is a virtual function.


After into kde4.0 we have:
KConfigSingleton::writeConfig()
{
    call: usrWriteConfig();
}

void KConfigSingleton::usrWriteConfig()
{
  save_data_from_kconfigSingleton();
}

So now data was not stored when we call writeConfig and redefine virtual 
function "usrWriteConfig()"

For me it's a bug. What do you think about it ?.
I create a patch to change it.

Regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: skeleton.patch
Type: text/x-diff
Size: 1529 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070516/7a185b00/attachment.patch>


More information about the kde-core-devel mailing list