KStyle changes

David Faure faure at kde.org
Wed May 9 17:53:51 BST 2007


On Wednesday 09 May 2007, Alex Merry wrote:
>          /// Represent as an int to store as a property
> -        operator int() const
> -        {
> -            return int(role) | int(mode);
> -        }
> +        operator int() const;

This could be replaced with a proper Q_DECLARE_FLAGS and Q_DECLARE_OPERATORS_FOR_FLAGS, I think?

Overall, I wonder if that ColorMode thing (just a glorified enum, right) is worth a Private class.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list