Enhance FOO_EXPORT macro

Christian Ehrlicher Ch.Ehrlicher at gmx.de
Fri May 4 12:05:20 BST 2007


Von: "Thiago Macieira" <thiago at kde.org>
> 
> Christian Ehrlicher said:
> > Maybe because KDE_IMPORT is not defined (correct) on linux?
> >
> > #ifdef __KDE_HAVE_GCC_VISIBILITY
> > #define KDE_NO_EXPORT __attribute__ ((visibility("hidden")))
> > #define KDE_EXPORT __attribute__ ((visibility("default")))
> > #define KDE_IMPORT
> >
> > But I don't know if it maybe breaks something when we define
> > KDE_IMPORT __attribute__ ((visibility("default")))
> >
> > Any comments?
> 
> You're right, it's not correctly defined. KDE_IMPORT and KDE_EXPORT should
> be the same on gcc/ELF.
> 
> On x86, you can get away with KDE_IMPORT being empty, but it breaks on
> 64-bit platforms.
> 
It should be changed after alpha1 is ready, then also the export macro creator (afair someone wrote a small script for this) should be updated.

Christian
-- 
"Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ...
Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail




More information about the kde-core-devel mailing list