[PATCH] Support for KUrl in KConfigXT and KCModule's

Andreas Pakulat apaku at gmx.de
Fri Mar 23 00:54:27 GMT 2007


On 20.03.07 01:11:21, Andreas Pakulat wrote:
> On 19.03.07 11:33:17, Aaron J. Seigo wrote:
> > On March 19, 2007, Andreas Pakulat wrote:
> > > as proposed I added support for KUrl to KConfigXT and
> > > KConfigDialogManager, the attached patch adds a new
> > > KConfigSkeletonItem and adds the two missing signals for
> > > change-notification to KConfigDialogManager. Luckily KUrlRequester
> > 
> > please follow the kdelibs style guidelines. otherwise, looks good.
> > 
> > > I'm not sure wether KUrl::List is needed as I don't see any widgets that
> > > work on such a type, but it should be relatively easy to add support for
> > > that.
> > 
> > widgets are only half the question; kconfigxt is used without UIs as well =)
> 
> Ok, here's an updated patch. Changes that are included:
> 
> a) the test for kconfig_compiler
> b) Support for KUrl::List
> c) using 4 space indentation for the new code in kconfigskeleton (I
> don't think reformatting all of the class is a good idea, as I only tuch
> a small part)
> 
> As I said I will commit this next week to give all people a chance to
> comment.

I should add that I couldn't test the KUrl::List change yet. The main
reason being that I don't know how to use all the KConfigSkeleton code
"by hand" (i.e. without a kcm) and "misusing" KUrlComboBox didn't work
out (the QVariant returned from widget->property("urls") didn't return a
QVariant with KUrl::List inside but rather QVariant(int, 0). (I did
change the API of KUrlComboBox from QStringList to KUrl::List of course).

So if anybody has a small snippet that I can embed into a basic kde4 app
to test wether reading/writing a KUrl::List works that would be much
appreciated.

Andreas

-- 
Tomorrow, you can be anywhere.




More information about the kde-core-devel mailing list